Skip to content

Invert if to the more consistent style #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Invert if to the more consistent style #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553779e
Invert if to the more consistent style
cristaloleg Sep 26, 2019
8c8aca5
Merge branch 'master' into invert-if
cristaloleg Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions handshake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,10 @@ func authenticateOrigin(r *http.Request) error {
if err != nil {
return fmt.Errorf("failed to parse Origin header %q: %w", origin, err)
}
if strings.EqualFold(u.Host, r.Host) {
return nil
if !strings.EqualFold(u.Host, r.Host) {
return fmt.Errorf("request Origin %q is not authorized for Host %q", origin, r.Host)
}
return fmt.Errorf("request Origin %q is not authorized for Host %q", origin, r.Host)
return nil
}

// DialOptions represents the options available to pass to Dial.
Expand Down