fix: add soft isolation mode and windows impl #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: than Dickson <[email protected]>
- Adds new switch to netns called SetCoderSoftIsolation - Adds a branch to the windows socket control function to determine whether soft isolation can be used for the given socket
ibetitsmike
reviewed
Jul 23, 2025
| growthEach := float64(growthTotal) / float64(num) | ||
| t.Logf("Alloced %v bytes, %.2f B/each", growthTotal, growthEach) | ||
| const max = 2000 | ||
| const max = 2500 |
There was a problem hiding this comment.
why did we increase the limit for the test?
Member
Author
There was a problem hiding this comment.
It was using 2018 bytes per run, no idea why
ibetitsmike
reviewed
Jul 23, 2025
ibetitsmike
reviewed
Jul 23, 2025
ethanndickson
approved these changes
Jul 23, 2025
Member
ethanndickson
left a comment
ethanndickson
left a comment
There was a problem hiding this comment.
lgtm, though I might have more thoughts once I'm done with the mac impl
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS impl to come later