-
Notifications
You must be signed in to change notification settings - Fork 55
add conda to Jfrog modules #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The code looks good can you please attach a video demo of this working in a Coder workspace? The conda package manager should show package resolution from the configured artifactory instance. |
I believe by "Cider" you mean "Coder" I am making a video for that |
Screencast.from.2025-08-25.22-23-13.mp4Everything is working fine the main reason it fails is you can see that i am having a jfrog(docker) not the real creds. |
Is it going to merge or anything left here?? |
@CodeMan62 testing it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds conda package manager support to the JFrog modules, allowing users to configure conda repositories for package management through Artifactory.
- Adds conda configuration support to both jfrog-token and jfrog-oauth modules
- Creates conda configuration templates that generate .condarc files with proper authentication
- Updates documentation and tests to include conda usage examples
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
registry/coder/modules/jfrog-token/run.sh | Adds conda configuration logic to create .condarc file |
registry/coder/modules/jfrog-token/main.tf | Adds conda package manager variable and template configuration |
registry/coder/modules/jfrog-token/main.test.ts | Adds test case for conda configuration with multiple repositories |
registry/coder/modules/jfrog-token/conda.conf.tftpl | Creates conda configuration template with channel URLs |
registry/coder/modules/jfrog-token/README.md | Updates documentation with conda usage examples |
registry/coder/modules/jfrog-oauth/run.sh | Adds conda configuration logic (duplicate of token module) |
registry/coder/modules/jfrog-oauth/main.tf | Adds conda package manager variable and template configuration |
registry/coder/modules/jfrog-oauth/main.test.ts | Adds test case for conda configuration |
registry/coder/modules/jfrog-oauth/conda.conf.tftpl | Creates conda configuration template |
registry/coder/modules/jfrog-oauth/README.md | Updates documentation with conda example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
I don't think we should go with these copilot suggesions as we can see in whole test file we haven't followed this pattern to put password token what do you think ?? |
@CodeMan62, I am getting the following error when testing the jfrog-oauth module
I am not sure if it's the config issue or what. |
The simple problem is the url you gave here is not valid it is not a config issue |
@CodeMan62, I am not adding a URL and just using the module. The module is configuring it. Can you show a video of this working for you? |
I will add it by tommorow thanks. |
here is video latest-jfrog-conda.mp4 |
I don't see You are getting a 40x error at 04:12 as per the video. |
It was a very simple mistake done by me putting wrong jfrog-url here is a new video complete video:- latestest-video-jfrog.mp4 |
Still not working for me and I get the same error shared above. |
can you please specify what command or operation you are running? |
@CodeMan62 |
I believe the problem is credentials that's why it is happening can you please use mine ones??
|
one more thing we can do is can you please ask anyone else in team to test it? |
@matifali any direction on it ?? |
Closes #34
Description
Jfrog Modules doesn't support conda package manager, This PR adds support of that
Type of Change
Testing & Validation
bun test
)bun run fmt
)Related Issues
#34
/claim #34