Protocol cleanup WIP #4053
Merged
Protocol cleanup WIP #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GirlBossRush
added
bug
|
✨ Coder.com for PR #4053 deployed! It will be updated on every commit.
|
GirlBossRush
force-pushed
the
3835-protocol-cleanup
branch
7 times, most recently
from
63ee582 to
7ced095
Compare
GirlBossRush
force-pushed
the
3835-protocol-cleanup
branch
from
7ced095 to
75e6f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This PR continues the cleanups introduced in #4010
Entry point, where code-server and vscode meet (A bit like oil and water)
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/entry.ts
Main Server Process
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/main.ts
Environment Service
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/environmentService.ts
WebSocket Handler
https://github.com/cdr/code-server/blob/3835-protocol-cleanup/lib/vscode/src/vs/server/connection/webSocketHandler.ts
TBD