Skip to content

feat(sse): add middleware to prevent proxy buffering of SSE connections #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

feat(sse): add middleware to prevent proxy buffering of SSE connections #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/httpapi/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,23 @@ func NewServer(ctx context.Context, config ServerConfig) (*Server, error) {
})
router.Use(corsMiddleware.Handler)

// Add SSE middleware to prevent proxy buffering
sseMiddleware := func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if strings.HasSuffix(r.URL.Path, "/events") || strings.HasSuffix(r.URL.Path, "/screen") {
// Disable proxy buffering for SSE endpoints
w.Header().Set("Cache-Control", "no-cache, no-store, must-revalidate")
w.Header().Set("Pragma", "no-cache")
w.Header().Set("Expires", "0")
w.Header().Set("X-Accel-Buffering", "no") // nginx
w.Header().Set("X-Proxy-Buffering", "no") // generic proxy
w.Header().Set("Connection", "keep-alive")
}
next.ServeHTTP(w, r)
})
}
router.Use(sseMiddleware)

humaConfig := huma.DefaultConfig("AgentAPI", "0.6.1")
humaConfig.Info.Description = "HTTP API for Claude Code, Goose, and Aider.\n\nhttps://github.com/coder/agentapi"
api := humachi.New(router, humaConfig)
Expand Down Expand Up @@ -388,6 +405,7 @@ func (s *Server) subscribeEvents(ctx context.Context, input *struct{}, send sse.
return
}
}

for {
select {
case event, ok := <-ch:
Expand Down