Skip to content

[BE] remove cut-n-paste support #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

senwang86
Copy link
Collaborator

Summary

The cut-n-paste was introduced in PR #165 , as the moveIntoScope #280 function was implemented, cut-n-paste seems unnecessary, this is a Better Engineering effort to reduce the tech debt.

  • The cut button is removed from the toolbar in Code/Scope pod.

@senwang86 senwang86 requested review from li-xin-yi and lihebi July 29, 2023 00:44
@lihebi
Copy link
Collaborator

lihebi commented Jul 29, 2023

We were talking about that cutting isn't necessary anymore. But after a second thought, I feel that cutting may still be useful in a few cases:

  1. Cut once and paste many times
  2. The cutting behavior is also slightly different from moving.
    • Cutting-n-pasting doesn't alter anything until clicked
    • Moving constantly changes the position of the pod being moved. Thus, DB and other peers see the changes in real-time.

@senwang86
Copy link
Collaborator Author

We were talking about that cutting isn't necessary anymore. But after a second thought, I feel that cutting may still be useful in a few cases:

  1. Cut once and paste many times

  2. The cutting behavior is also slightly different from moving.

    • Cutting-n-pasting doesn't alter anything until clicked
    • Moving constantly changes the position of the pod being moved. Thus, DB and other peers see the changes in real-time.

The moving effect of the cutting pod is very fancy and I like it, as it shows that "cutting" is taking place; I think copy-n-paste should apply the same effect to indicate that "copy" is happening.

I am OK with either choice, while I don't think cutting has a strong use case; If cutting isn't regularly used, we might think about moving the button from the toolbar to another location.

@senwang86
Copy link
Collaborator Author

PR #452 address the topic.

@senwang86 senwang86 closed this Aug 15, 2023
@senwang86 senwang86 deleted the remove_cut_n_past branch September 7, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants