Skip to content

proper scope highlighting #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

proper scope highlighting #235

merged 1 commit into from
Apr 21, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Apr 21, 2023

"Highlighting a scope" currently means adding a box-shadow. A scope is highlighted when:

  1. it is "selected" by clicking on its header bar
  2. the user move a pod over it, indicating the recipient scope

Specifically, this PR:

  1. remove the hovering highlight because it's confusing and too eye-catching
  2. fix the logic of removing the highlighting at the dragging end.

@lihebi lihebi changed the title fix scope highlight fix scope highlighting Apr 21, 2023
@lihebi lihebi changed the title fix scope highlighting proper scope highlighting Apr 21, 2023
@lihebi lihebi merged commit 884738c into codepod-io:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lihebi