Skip to content

fix(node_delete): check pod #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix(node_delete): check pod #18

merged 1 commit into from
Nov 4, 2022

Conversation

li-xin-yi
Copy link
Collaborator

Delete a code node without crashing. It also removes the record in database.

TODO

  • Add some easy-to-use UIs for deletion
  • Improve when merging with the collaborative editing feature

@li-xin-yi li-xin-yi requested a review from lihebi November 4, 2022 04:32
@lihebi lihebi merged commit da04cae into codepod-io:main Nov 4, 2022
@li-xin-yi li-xin-yi deleted the fix/node_delete branch December 13, 2022 22:19
lihebi added a commit to lihebi/codepod that referenced this pull request Dec 25, 2023
@lihebi
add back k8s files (codepod-io#18)
3d89ebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihebi lihebi lihebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@li-xin-yi @lihebi