fix: fixes substitution issue with classpaths #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the classpath substitution logic incorrectly identified Maven plugin options (like "spotless:apply") as classpaths that needed substitution. The fix adds validation to ensure only legitimate file paths with at least one directory separator are considered for classpath substitution.
- Adds a validation check to prevent false positive classpath detection
- Refactors the substitution logic into separate methods for better testability
- Updates app.yml to remove incorrect substitution markers from Maven commands
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/codejive/jpm/util/ScriptUtils.java | Adds validation logic to prevent Maven plugin options from being treated as classpaths and refactors substitution methods |
| src/test/java/org/codejive/jpm/util/ScriptUtilsTest.java | Adds test case to verify that Maven plugin options are not incorrectly substituted |
| app.yml | Removes incorrect substitution markers from Maven commands that were falsely identified as classpaths |
Some normal options like "plugin:apply" were taken to be a classpath and where marked for substitution. We now properly ignore them. Fixes #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some normal options like "plugin:apply" were taken to be a classpath and where marked for substitution. We now properly ignore them.
Fixes #68