Skip to content

Conversation

quintesse
Copy link
Contributor

@quintesse quintesse commented Sep 3, 2025

Fixes #64

@quintesse quintesse requested a review from Copilot September 3, 2025 10:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for multiple search backends in the jpm tool by refactoring the search functionality into a pluggable architecture. The main changes extract the existing search implementation into a modular interface-based design while maintaining backward compatibility.

  • Introduces a new Search interface with a factory method to select search backends
  • Refactors existing SearchUtils class into SearchSmoRestImpl implementing the new interface
  • Moves SearchResult as a nested class within the Search interface
  • Adds integration tests for the new search backend architecture

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/java/org/codejive/jpm/util/Search.java New interface defining search contract with factory method and nested SearchResult class
src/main/java/org/codejive/jpm/util/SearchSmoRestImpl.java Refactored SearchUtils to implement Search interface with updated method signatures
src/main/java/org/codejive/jpm/util/SearchResult.java Removed standalone class (moved to nested class in Search interface)
src/main/java/org/codejive/jpm/Jpm.java Updated to use new Search interface instead of static SearchUtils methods
src/main/java/org/codejive/jpm/Main.java Reordered subcommands in CLI configuration
src/it/java/org/codejive/jpm/util/SearchIT.java New integration tests for search backend functionality
src/it/java/org/codejive/jpm/MainIT.java Renamed test class from MainIntegrationTest to MainIT
pom.xml Added Maven plugins for integration test support

@quintesse quintesse force-pushed the search branch 3 times, most recently from 772ed76 to 867b8aa Compare September 3, 2025 11:18
@quintesse quintesse force-pushed the search branch 2 times, most recently from bb4e687 to ef6cd9e Compare September 3, 2025 19:33
They use the exact same endpoints as the other two
backends while giving worse results. Just not worth
keeping them around. Won't remove the code yet.
@quintesse quintesse marked this pull request as ready for review September 3, 2025 21:20
@quintesse quintesse merged commit 78f14a1 into main Sep 3, 2025
2 checks passed
@quintesse quintesse deleted the search branch September 3, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement additional search backends

1 participant