Skip to content

Conversation

@datamweb
Copy link
Collaborator

@datamweb datamweb commented Oct 17, 2023

Description
The production date by mkdocs-git-revision-date-localized-plugin on local is correct, this is due to local access to .git.
Now in the online mode, these dates are displayed incorrectly. This PR is trying to address this issue.
I already tested here.

  • fix Last update&Created
  • refactor action steps

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added github_actions Pull requests that update GitHub Actions code documentation Improvements or additions to documentation labels Oct 17, 2023
@kenjis
Copy link
Member

kenjis commented Oct 17, 2023

@datamweb The shield-oauth docs seems good, but why does this change fix the date issue?

@datamweb
Copy link
Collaborator Author

@kenjis Yes, the shield-oauth docs date problem was solved after the recent change.

The reason for solving the date problem is the following code snippet.

uses: actions/checkout@v4
        with:
          fetch-depth: 0

Because it allows the plugin to access to the last commit that touched a specific file to be able to retrieve the date.

More info see here .

@kenjis
Copy link
Member

kenjis commented Oct 17, 2023

Oh, I got it!

Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags.
https://github.com/actions/checkout

@datamweb datamweb merged commit b42574d into codeigniter4:develop Oct 17, 2023
@datamweb datamweb deleted the fix-mkdocs-date-localized-plugin branch October 17, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants