Skip to content

mkdocs: improve dark mode #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 27, 2023
Merged

mkdocs: improve dark mode #859

merged 5 commits into from
Sep 27, 2023

Conversation

@datamweb
Copy link
Collaborator

@datamweb datamweb commented Sep 26, 2023 •
edited
Loading

Description
Online Demo: https://datamweb.github.io/shield

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lonnieezell lonnieezell merged commit 82f0ee5 into codeigniter4:develop Sep 27, 2023
@datamweb datamweb deleted the improve-dark-mode branch September 27, 2023 04:25
@kenjis kenjis changed the title docs: improve dark mode mkdocs: improve dark mode Oct 3, 2023
@kenjis kenjis added the enhancement New feature or request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@datamweb @kenjis @lonnieezell