Skip to content

fix: add missing validation for group name to shield:user addgroup/removegroup #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2024
Merged

fix: add missing validation for group name to shield:user addgroup/removegroup #1176

merged 2 commits into from
Aug 24, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 21, 2024

Description
See #1164 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Something isn't working label Aug 21, 2024
@kenjis kenjis merged commit 918051a into codeigniter4:develop Aug 24, 2024
@kenjis kenjis deleted the add-group-validation-to-user-command branch August 24, 2024 00:27
@michalsn michalsn mentioned this pull request Jul 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamweb datamweb datamweb approved these changes

+1 more reviewer

@christianberkman christianberkman christianberkman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @christianberkman