Skip to content

Conversation

@pmagictech
Copy link
Contributor

@pmagictech pmagictech commented Jun 7, 2024

Description
This pull request enhances the existing email templates by including the username of the recipient. This update aims to improve the personalization of the emails, making the communication more engaging and user-friendly. By making the User Entity object accessible in the email templates, Shield users can now easily add user-specific details, tailoring the emails to better suit their needs.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement New feature or request tests needed Pull requests that need tests labels Jun 7, 2024
@kenjis kenjis changed the title Updated email templates with user information feat: Updated email templates with user information Jun 7, 2024
@kenjis
Copy link
Member

kenjis commented Jun 13, 2024

Thank you for sending this PR.

We don't accept PRs without test code that proves the change works properly.
Please add test code.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR.
You can get help from Email Test for write the test.

@pmagictech pmagictech requested a review from datamweb June 13, 2024 11:44
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update description https://github.com/codeigniter4/shield/blob/develop/docs/customization/views.md#customize-content and explain that user data(User Entity object) in email tpls is now available?

@pmagictech pmagictech requested a review from datamweb June 13, 2024 13:39
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🫡!

@datamweb datamweb requested a review from kenjis June 14, 2024 20:11
@datamweb datamweb removed the tests needed Pull requests that need tests label Jun 14, 2024
@kenjis kenjis merged commit 4507f1b into codeigniter4:develop Jun 15, 2024
@kenjis
Copy link
Member

kenjis commented Jun 15, 2024

@pmagictech Thank you!

@pmagictech
Copy link
Contributor Author

@kenjis You are welcome

@michalsn michalsn mentioned this pull request Jul 14, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants