-
Notifications
You must be signed in to change notification settings - Fork 143
feat: Updated email templates with user information #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for sending this PR. We don't accept PRs without test code that proves the change works properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR.
You can get help from Email Test for write the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update description https://github.com/codeigniter4/shield/blob/develop/docs/customization/views.md#customize-content and explain that user data(User Entity object) in email tpls is now available?
datamweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🫡!
|
@pmagictech Thank you! |
|
@kenjis You are welcome |
Description
This pull request enhances the existing email templates by including the username of the recipient. This update aims to improve the personalization of the emails, making the communication more engaging and user-friendly. By making the User Entity object accessible in the email templates, Shield users can now easily add user-specific details, tailoring the emails to better suit their needs.
Checklist: