Skip to content

test: fix Registrar for DB Config #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2024
Merged

test: fix Registrar for DB Config #1094

merged 2 commits into from
Apr 14, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Apr 9, 2024 •
edited
Loading

Description
Fixes a serious bug in DB testing configuration.

phpunit / PHP 8.1 - MySQLi
...
1) Tests\Authentication\Authenticators\HmacAuthenticatorTest::testAttemptCannotFindUser
TypeError: CodeIgniter\Database\SQLite3\Connection::_escapeString(): Argument #1 ($str) must be of type string, CodeIgniter\I18n\Time given, called in /home/runner/work/shield/shield/vendor/codeigniter4/framework/system/Database/BaseConnection.php on line 1346
...

https://github.com/codeigniter4/shield/actions/runs/8600000130/job/23564066896

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Apr 9, 2024
@kenjis
test: fix too long secret2
ed2e21b 
mysqli_sql_exception: Data too long for column 'secret2' at row 1
@kenjis kenjis merged commit 112d44b into codeigniter4:develop Apr 14, 2024
@kenjis kenjis deleted the fix-test-DB-config branch April 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @datamweb