Skip to content

Conversation

@MGatner
Copy link
Member

@MGatner MGatner commented Feb 25, 2022

Composer Unused 0.8.1 has a couple new features desirable for this kit:

  • Formatters: Besides the default formatter results can be output as GitHub annotations
  • File configuration: Now reads in supplemental information from a config file

This PR implements the new GitHub formatter (though in most cases it should be detected automatically) and adds an example config file to the Template.

@MGatner MGatner requested a review from kenjis February 25, 2022 17:00
@kenjis
Copy link
Member

kenjis commented Feb 26, 2022

@MGatner These lines are not necessary:

- name: Create PHPStan cache directory
run: mkdir -p build/phpstan
- name: Cache PHPStan results
uses: actions/cache@v2
with:
path: build/phpstan
key: ${{ runner.os }}-phpstan-${{ github.sha }}
restore-keys: ${{ runner.os }}-phpstan-

@MGatner
Copy link
Member Author

MGatner commented Feb 26, 2022

You are very right! Those must have crept in a while ago on a copy-paste boat.

@kenjis kenjis merged commit 786e5aa into develop Feb 26, 2022
@kenjis kenjis deleted the unused branch February 26, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants