feat: add docker-compose.yaml for databases #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
requested changes
Feb 17, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
I'm not great with Docker, if someone else could vet that config. I'm not sure who uses it, @paulbalandan ?
For the README I'm of the opinion that Template/ should only include the files mergable with the project/library and that docs would make more sense in the root of src/. Feel free to discuss.
Member
Author
|
Moved to |
Member
|
Should we include MySQL or MariaDB also? |
Member
Author
|
Added MySQL. |
lonnieezell
approved these changes
Feb 18, 2022
MGatner
approved these changes
Feb 19, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Very nice, happy to have an official version of this available. Might even be worth mentioning in the framework User Guide?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.