Skip to content

chore: move rector from require-dev to require #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2023
Merged

chore: move rector from require-dev to require #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8376398
chore: move rector from require-dev to require
kenjis Sep 11, 2023
4b4e0d6
docs: fix Note format in GitHub markdown
kenjis Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ predefined rulesets. Rector can be highly opinionated based on its configuration
so be sure to read the documentation and figure out the best fit for you. This workflow performs
a "dry run" to check for any changes that Rector would have made and fail if there are matches.

> Note: Rector updates rules all the time, so you may want to lock your repo to
> **Note**
> Rector updates rules all the time, so you may want to lock your repo to
> the latest known working version of Rector to prevent unexpected failures.
> Using pinned version in `composer.json` and update it with dependabot is the
> best practice.
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
"phpstan/phpstan-phpunit": "^1.0",
"phpunit/phpunit": "^9.3",
"roave/security-advisories": "dev-latest",
"vimeo/psalm": "^5.0"
"vimeo/psalm": "^5.0",
"rector/rector": "^0.18.3"
},
"require-dev": {
"codeigniter4/framework": "^4.1",
"icanhazstring/composer-unused": "^0.8.2",
"rector/rector": "0.18.3"
"icanhazstring/composer-unused": "^0.8.2"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down