Skip to content

Conversation

@neznaika0
Copy link
Contributor

Description

  • Added information about the method

https://forum.codeigniter.com/showthread.php?tid=88747

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions and changes to make the code example a little more realistic.

@neznaika0
Copy link
Contributor Author

@michalsn thanks, changed

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@michalsn michalsn added the documentation Pull requests for documentation only label Feb 5, 2025
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulbalandan paulbalandan merged commit efcabb3 into codeigniter4:develop Feb 7, 2025
9 checks passed
@neznaika0 neznaika0 deleted the docs/add-router-note branch February 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants