Skip to content

refactor: improve error message in BaseExceptionHandler #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor: improve error message in BaseExceptionHandler #8766

merged 2 commits into from
Apr 12, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Apr 12, 2024 •
edited
Loading

Description
See https://forum.codeigniter.com/showthread.php?tid=90626

  • improve error message
  • replace empty()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Apr 12, 2024
datamweb
datamweb approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kenjis kenjis merged commit 73ffc06 into codeigniter4:develop Apr 12, 2024
@kenjis kenjis deleted the fix-ExceptionHandler-error-msg branch April 12, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @datamweb