Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 29, 2024

Description

  • fix PHPDoc types
 ------ ------------------------------------------------------------------------- 
  Line   src/Models/LoginModel.php                                                
 ------ ------------------------------------------------------------------------- 
  37     Property CodeIgniter\Shield\Models\LoginModel::$validationRules          
         (list<string>|string) does not accept default value of type              
         array{ip_address: 'required', id_type: 'required', identifier:           
         'permit_empty|string', user_agent: 'permit_empty|string', user_id:       
         'permit_empty', date: 'required'}.                                       
         💡 Type #1 from the union: array{ip_address: 'required', id_type:         
            'required', identifier: 'permit_empty|string', user_agent:            
            'permit_empty|string', user_id: 'permit_empty', date: 'required'} is  
            not a list.                                                           
 ------ ------------------------------------------------------------------------- 

https://github.com/codeigniter4/shield/actions/runs/8480994004/job/23237640319

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 29, 2024
@kenjis kenjis merged commit 3b86d09 into codeigniter4:develop Mar 30, 2024
@kenjis kenjis deleted the fix-phpdoc-type-BaseModel branch March 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants