Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 23, 2024

Description

Let's try enable rector cache based on https://getrector.com/documentation/cache-in-ci

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

It seems working ok with merge multiple paths to single:

Before Time: 2m 43s

ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/8403997993/job/23015107946#step:11:1

After Time: 2s

ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/8404013987/job/23015144926?pr=8655#step:11:1

Ready to merge 👍

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Mar 23, 2024
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samsonasik samsonasik merged commit f82dc32 into codeigniter4:develop Mar 23, 2024
@samsonasik samsonasik deleted the rector-cache branch March 23, 2024 22:15
@kenjis
Copy link
Member

kenjis commented Mar 23, 2024

@samsonasik Can you update .github and devkit repositories?

@samsonasik
Copy link
Member Author

@kenjis yes, I created PR:

for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants