Skip to content

Conversation

@obozdag
Copy link
Contributor

@obozdag obozdag commented Mar 22, 2024

Description
Small typo in factories.rst. Change all "full qualified classname" to "fully qualified classname".

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Small typo in factories.rst. Change all "full qualified classname" to "fully qualified classname".
@kenjis kenjis added the documentation Pull requests for documentation only label Mar 22, 2024
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 8f4e848 into codeigniter4:develop Mar 22, 2024
@obozdag
Copy link
Contributor Author

obozdag commented Mar 23, 2024

@kenjis on security.rst page A6 Sensitive Data Exposure and A7 Missing Function Level Access Control sections have the same description. I would like to change it but I cannot find what it was before. In fact this page needs a complete update. When you follow the OWASP Top Ten Cheat Sheet link on top of the page you can see that this sheet is changed. Do you have any idea or suggestion on how to update the CodeIgniter Security Guidelines page? (I had to write this comment here, I don't know how to comment on security.rst page without creating a pull request for it.)

@kenjis
Copy link
Member

kenjis commented Mar 23, 2024

@obozdag See #7390

@obozdag obozdag deleted the patch-5 branch March 23, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants