Skip to content

refactor: remove unnecessary BaseService::$services assignment #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2024
Merged

refactor: remove unnecessary BaseService::$services assignment #8609

merged 2 commits into from
Mar 5, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 5, 2024 •
edited
Loading

Description

  • deprecate BaseService::$services. It is not used elsewhere.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Mar 5, 2024
@kenjis kenjis merged commit 87db593 into codeigniter4:4.5 Mar 5, 2024
@kenjis kenjis deleted the deprecate-BaseConfig-services branch March 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan