Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 3, 2024

Description
Supersedes #8558

The following items are also needed, so included in this PR:

  • move CodeIgniter::bootstrapEnvironment() to bootstrap.php
  • move Services::exceptions()->initialize() to bootstrap.php
  • move CodeIgniter::resolvePlatformExtensions() to bootstrap.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.5 labels Mar 3, 2024
@kenjis kenjis force-pushed the fix-move-kint-autoload branch 2 times, most recently from 800a39a to 0d70fb8 Compare March 4, 2024 00:33
@kenjis kenjis added the breaking change Pull requests that may break existing functionalities label Mar 4, 2024
@github-actions
Copy link

github-actions bot commented Mar 7, 2024

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@github-actions github-actions bot added the stale Pull requests with conflicts label Mar 7, 2024
@kenjis kenjis force-pushed the fix-move-kint-autoload branch from 0d70fb8 to 6ca5c66 Compare March 7, 2024 07:39
@kenjis kenjis removed the stale Pull requests with conflicts label Mar 7, 2024
@kenjis kenjis force-pushed the fix-move-kint-autoload branch from 6ca5c66 to 2df2f93 Compare March 10, 2024 09:59
@kenjis
Copy link
Member Author

kenjis commented Mar 11, 2024

This is the first PR of a story.
See the next #8604, #8605, and #8610.

* ---------------------------------------------------------------
*/

if (! defined('APP_NAMESPACE')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this always be defined because it was required for the Autoloader?

public $psr4 = [
    APP_NAMESPACE => APPPATH, // For custom app namespace
    'Config'      => APPPATH . 'Config',
];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is defined in app/Config/Constants.php.

@kenjis kenjis force-pushed the fix-move-kint-autoload branch from b5dea64 to 458333c Compare March 15, 2024 12:08
@kenjis kenjis requested a review from MGatner March 15, 2024 12:23
@kenjis kenjis merged commit b50cfbd into codeigniter4:4.5 Mar 16, 2024
@kenjis kenjis deleted the fix-move-kint-autoload branch March 16, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants