Skip to content

refactor: remove deprecated BaseService::discoverServices() #8589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2024
Merged

refactor: remove deprecated BaseService::discoverServices() #8589

merged 3 commits into from
Mar 5, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Feb 27, 2024

Description

  • remove deprecated BaseService::discoverServices()

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.5 labels Feb 27, 2024
@kenjis
Copy link
Member Author

kenjis commented Mar 4, 2024

Can someone approve?

@kenjis kenjis merged commit a663b36 into codeigniter4:4.5 Mar 5, 2024
@kenjis kenjis deleted the remove-BaseService-discoverServices branch March 5, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees

No one assigned

Labels

breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @lonnieezell