Skip to content

docs: improve contributing/signing.md #8475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2024
Merged

docs: improve contributing/signing.md #8475

merged 2 commits into from
Jan 30, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jan 29, 2024

Description

  • add "Set Default Signing" section and refer it

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis merged commit aaef1de into codeigniter4:develop Jan 30, 2024
@kenjis kenjis deleted the docs-contrib-signing branch January 30, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@ddevsr ddevsr ddevsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @paulbalandan @ddevsr