Skip to content

Conversation

@paulbalandan
Copy link
Member

Description
This refactors the test to:

  • check all available sources of the convert program
  • move the extension_loaded check to the native PHPUnit annotation
  • fail gracefully and skip the tests altogether if convert is missing instead of erroring midway through the test, i.e. Esh: /usr/local/bin/convert: No such file or directory

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Jan 26, 2024
@paulbalandan paulbalandan merged commit 3734bbb into codeigniter4:develop Jan 27, 2024
@paulbalandan paulbalandan deleted the imagick-convert branch January 27, 2024 17:52
@kenjis kenjis added the refactor Pull requests that refactor code label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants