Skip to content

[4.5] refactor: add strict_types in SQLite3\GetFieldDataTest #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

[4.5] refactor: add strict_types in SQLite3\GetFieldDataTest #8437

merged 1 commit into from
Jan 22, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jan 20, 2024 •
edited
Loading

Description
Follow-up #8432

  • add strict_types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only 4.5 labels Jan 20, 2024
@kenjis kenjis merged commit cdaee9d into codeigniter4:4.5 Jan 22, 2024
@kenjis kenjis deleted the test-SQLite3-GetFieldDataTest branch January 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@ddevsr ddevsr ddevsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @ddevsr