-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: enforce PR title format with PRLint Reloaded #8394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enforce PR title format with PRLint Reloaded #8394
Conversation
|
I'm not sure what others will say, but I believe we were thinking of going in the opposite direction in terms of tightening PR requirements. Potentially speaking... every commit would be checked, or only the most recent? |
|
This approach only checks PR titles upon creation, not commit messages involved in the PR, correct? If so, I think this is quite useful and not a hurdle keeping beginners from contributing. |
|
Ok, maybe I didn't fully understand it. If only the PR title is checked, I would be fine with it. |
a4509ff to
817c482
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding how and when this works then I think this is fine. Will also make compiling our changelogs simpler.
|
@lonnieezell thanks for the approval! can you install the Github app to the org so this can be merged? |
Sure. How would I do this? |
|
Install it from here: https://github.com/marketplace/prlintreloaded |
|
@paulbalandan Should be installed now for the codeigniter4 org. |
817c482 to
53d1382
Compare
|
Rebased to test the app. And all passed 🎉 |
Description
Enforce Conventional Commit format of PR title using PRLint Reloaded
Step 1: Allow access to the
codeigniter4org then to this repo for the app (I have no rights to do so)Step 2: Merge this PR to let the configuration kick in
For the regex reference: https://regex101.com/r/Yh1iT9/1
Checklist: