Skip to content

Conversation

@paulbalandan
Copy link
Member

Description
Enforce Conventional Commit format of PR title using PRLint Reloaded

Step 1: Allow access to the codeigniter4 org then to this repo for the app (I have no rights to do so)
Step 2: Merge this PR to let the configuration kick in

For the regex reference: https://regex101.com/r/Yh1iT9/1

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member

I'm not sure what others will say, but I believe we were thinking of going in the opposite direction in terms of tightening PR requirements.

Potentially speaking... every commit would be checked, or only the most recent?

@sfadschm
Copy link
Contributor

This approach only checks PR titles upon creation, not commit messages involved in the PR, correct?

If so, I think this is quite useful and not a hurdle keeping beginners from contributing.

@michalsn
Copy link
Member

Ok, maybe I didn't fully understand it. If only the PR title is checked, I would be fine with it.

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Dec 30, 2023
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding how and when this works then I think this is fine. Will also make compiling our changelogs simpler.

@paulbalandan
Copy link
Member Author

@lonnieezell thanks for the approval! can you install the Github app to the org so this can be merged?

@lonnieezell
Copy link
Member

@lonnieezell thanks for the approval! can you install the Github app to the org so this can be merged?

Sure. How would I do this?

@paulbalandan
Copy link
Member Author

Install it from here: https://github.com/marketplace/prlintreloaded

@lonnieezell
Copy link
Member

@paulbalandan Should be installed now for the codeigniter4 org.

@paulbalandan
Copy link
Member Author

Rebased to test the app. And all passed 🎉

@paulbalandan paulbalandan merged commit 3013218 into codeigniter4:develop Jan 2, 2024
@paulbalandan paulbalandan deleted the prlint-reloaded branch January 2, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants