Skip to content

refactor: remove overrides for coding-standard v1.7.12 #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 29, 2023
Merged

refactor: remove overrides for coding-standard v1.7.12 #8386

merged 2 commits into from
Dec 29, 2023

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Dec 29, 2023

Description

  • removed overrides (already in latest release)
  • manually fixes leftover cases for phpunit_data_provider_static

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Dec 29, 2023
@kenjis kenjis merged commit 4c3f90c into codeigniter4:develop Dec 29, 2023
@paulbalandan paulbalandan deleted the coding-standard branch December 30, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @kenjis @michalsn