Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Dec 25, 2023

Description

1 file with changes
===================

1) tests/_support/Entity/Cast/CastBase64.php:21

    ---------- begin diff ----------
@@ @@
      *
      * @param mixed $value  Data
      * @param array $params Additional param
-     *
-     * @return mixed
      */
     public static function get($value, array $params = []): string
     {
@@ @@
      *
      * @param mixed $value  Data
      * @param array $params Additional param
-     *
-     * @return mixed
      */
     public static function set($value, array $params = []): string
     {
    ----------- end diff -----------

Applied rules:
 * RemoveUselessReturnTagRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7324536612/job/19948207442?pr=8364

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Dec 25, 2023
@kenjis kenjis merged commit 5a52b60 into codeigniter4:develop Dec 26, 2023
@kenjis kenjis deleted the fix-test-CastBase64 branch December 26, 2023 01:05
@kenjis
Copy link
Member Author

kenjis commented Dec 26, 2023

@ddevsr Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants