Skip to content

refactor: TestResponse is now a class of its own #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 29, 2023
Merged

refactor: TestResponse is now a class of its own #8264

merged 8 commits into from
Nov 29, 2023

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Nov 28, 2023 •
edited
Loading

Description
Replaces and closes #8181

  • Remove extends on PHPUnit\Framework\TestCase
  • Natively type void the return types of assertions

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis reviewed Nov 28, 2023
View reviewed changes
@kenjis kenjis added 4.5 refactor Pull requests that refactor code labels Nov 28, 2023
@paulbalandan paulbalandan force-pushed the test-response-refactor branch from 1824905 to f28b345 Compare November 28, 2023 03:09
kenjis
kenjis reviewed Nov 28, 2023
View reviewed changes
@paulbalandan paulbalandan force-pushed the test-response-refactor branch from f28b345 to 0174ad3 Compare November 28, 2023 05:51
@paulbalandan paulbalandan merged commit 9208a60 into codeigniter4:4.5 Nov 29, 2023
@paulbalandan paulbalandan deleted the test-response-refactor branch November 29, 2023 04:10
@paulbalandan paulbalandan mentioned this pull request Nov 30, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @kenjis @michalsn