fix: set_cookie() $expire type #8080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the docs, the param
$expireis "Number of seconds until expiration", and the type isint:https://www.codeigniter.com/user_guide/helpers/cookie_helper.html#set_cookie
So it should be
int, notstring.The param
$expires_or_optionsforsetcookie()is alsoint.https://www.php.net/manual/en/function.setcookie.php
Checklist: