-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: fix: event trigger label conflict #7936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you sure that this PR is safe? |
|
I would not advocate to use |
|
If we use |
|
Anyway, the Member adds the label stale. I think similar to smart commenting safely. |
|
I admit that |
|
@ddevsr can you try putting the permissions inside the specific job instead of outside? also change the token to |
|
@kenjis @paulbalandan @datamweb I already change to implement smart commenting codeigniter4/shield#812 |
929a285 to
209e4bb
Compare
|
@paulbalandan @kenjis I tested with result https://github.com/codeigniter4/CodeIgniter4/actions/runs/6193689315/job/16815562654?pr=7936 |
|
try add contents: write permission |
|
https://github.com/codeigniter4/CodeIgniter4/actions/runs/6193902891/job/16816111260?pr=7936 Setup job still permission |
|
Because you sent the PR from your repository. |
|
https://github.com/orgs/community/discussions/63736 Give permissions above if conditions. @kenjis Oh, okay |
|
Now let's merge and test. |
| on: | ||
| pull_request: | ||
| branches: | ||
| - 'develop' | ||
| - '4.*' | ||
| types: | ||
| - labeled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be?
on:
pull_request:
types:
- labeled
Description
Based on https://github.com/actions/labeler#permissions and https://github.com/prince-chrismc/label-merge-conflicts-action#faq---how-do-i-fix-resource-not-accessible-by-integration must using event
pull_request_targetFollow-up #7928
Checklist: