Skip to content

chore: auto label conflict PR #7921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2023
Merged

chore: auto label conflict PR #7921

merged 4 commits into from
Sep 11, 2023

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 11, 2023

Description
I think this help

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the github_actions Pull requests that update Github_actions code label Sep 11, 2023
kenjis
kenjis reviewed Sep 11, 2023
View reviewed changes
kenjis
kenjis reviewed Sep 11, 2023
View reviewed changes
kenjis
kenjis approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would help us!

paulbalandan
paulbalandan reviewed Sep 11, 2023
View reviewed changes
@ddevsr ddevsr requested a review from paulbalandan September 11, 2023 08:50
@kenjis kenjis merged commit f314d0a into codeigniter4:develop Sep 11, 2023
@kenjis
Copy link
Member

kenjis commented Sep 11, 2023

@ddevsr Thank you!

@kenjis
Copy link
Member

kenjis commented Sep 11, 2023

Sorry, this does not work.
We need to rework.

  1. the place of the file is wrong.
  2. if the PR is not updated, the check does not run.

@ddevsr ddevsr deleted the patch-2 branch September 12, 2023 01:09
@ddevsr
Copy link
Collaborator Author

ddevsr commented Sep 12, 2023

The file must in workflows?

@kenjis
Copy link
Member

kenjis commented Sep 12, 2023

Yes.
See https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions#create-an-example-workflow

@ddevsr ddevsr mentioned this pull request Sep 12, 2023
Merged
5 tasks
@ddevsr
Copy link
Collaborator Author

ddevsr commented Sep 12, 2023

@kenjis I make PR to moving #7928

@kenjis kenjis changed the title GH: auto label conflict PR chore: auto label conflict PR Sep 12, 2023
@kenjis
Copy link
Member

kenjis commented Sep 12, 2023

@ddevsr Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr @kenjis @paulbalandan