Skip to content

refactor: remove unneeded arguments to session #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

refactor: remove unneeded arguments to session #7919

merged 1 commit into from
Sep 11, 2023

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Sep 11, 2023

Description
(null, true) are the default values

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the refactor Pull requests that refactor code label Sep 11, 2023
@kenjis kenjis merged commit 6c4f668 into codeigniter4:develop Sep 11, 2023
@paulbalandan paulbalandan deleted the session-service branch September 11, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @kenjis @ddevsr