Skip to content

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Sep 7, 2023

Description
Before:
image

After:
image

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 7, 2023
@kenjis
Copy link
Member

kenjis commented Sep 7, 2023

SCSS Compilation failed.

Please update scss file, not css.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/css.md

Run if [[ -n "$(git status --porcelain 2>/dev/null)" ]]; then
Your changes to the SCSS files did not match the expected CSS output.
diff --git a/system/Debug/Toolbar/Views/toolbar.css b/system/Debug/Toolbar/Views/toolbar.css
index dbcc16c..8a302b4 100644
--- a/system/Debug/Toolbar/Views/toolbar.css
+++ b/system/Debug/Toolbar/Views/toolbar.css
@@ -532,9 +532,6 @@
   #debug-bar .timeline .timer {
     background-color: #DD8615;
   }
-  #debug-bar .timeline .timeline-parent-open td {
-    color: #252525;
-  }
   .debug-view.show-view {
     border-color: #DD8615;
   }
Error: Process completed with exit code 1.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6107557785/job/16574808670?pr=7907

@kenjis kenjis changed the title fix: dark mode timeline-color-open color text on Debug fix: [DebugBar] dark mode timeline-color-open color text on Debug Sep 7, 2023
@ddevsr ddevsr requested a review from kenjis September 7, 2023 09:08
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 10b2514 into codeigniter4:develop Sep 11, 2023
@kenjis
Copy link
Member

kenjis commented Sep 11, 2023

@ddevsr Thank you!

@kenjis
Copy link
Member

kenjis commented Nov 3, 2023

Reverted by #8125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants