Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Sep 6, 2023

Description

  • replace deprecated sets

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft September 6, 2023 09:24
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Sep 7, 2023
@kenjis kenjis marked this pull request as ready for review September 7, 2023 06:55
It caused an error.

Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209

Error: ] Could not process
         "/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
         onse.php" file, due to:
         "System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
         Return value must be of type int, null returned"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
         209

Error: Process completed with exit code 1.
@kenjis
Copy link
Member Author

kenjis commented Sep 8, 2023

Rebased to resolve conflict.

@samsonasik samsonasik merged commit 64819ee into codeigniter4:develop Sep 8, 2023
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the update-rector.php branch September 8, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants