Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
81cead1
docs: update RELEASE.md
kenjis Aug 25, 2023
a2e8e5c
fix: add types for cache handlers
paulbalandan Aug 25, 2023
7e11339
docs: add missing Mandatory File Changes for Hot Reload
kenjis Aug 25, 2023
c34ae21
docs: remove `-` for listing
kenjis Aug 25, 2023
07d8868
Merge pull request #7856 from kenjis/docs-RELEASE.md
kenjis Aug 26, 2023
4bb67f2
docs: changelog and upgrade for 4.4.1
kenjis Aug 26, 2023
60b22bf
Merge pull request #7863 from kenjis/docs-changelog-4.4.1
kenjis Aug 26, 2023
1f09614
Merge pull request #7858 from paulbalandan/phpstan-cache-types
kenjis Aug 26, 2023
98239ad
Merge pull request #7862 from kenjis/fix-docs-missing-config-update
kenjis Aug 26, 2023
9dd7cb0
test: add test when filter returns response
kenjis Aug 27, 2023
e28b9d7
fix: add missing outputBufferingEnd()
kenjis Aug 27, 2023
1e91936
docs: suppress paslm error
kenjis Aug 27, 2023
936d298
test: add test for get same config with different alias
kenjis Aug 27, 2023
42f90a2
fix: Factories do not return shared instance
kenjis Aug 27, 2023
3924339
fix: Config cache may not be updated
kenjis Aug 27, 2023
65a1385
refactor: extract method
kenjis Aug 27, 2023
896b047
refactor: extract method
kenjis Aug 27, 2023
a895f63
refactor: move logic
kenjis Aug 27, 2023
add2cbd
refactor: change if condition
kenjis Aug 27, 2023
1b88479
refactor: remove unnecessary verifyInstanceOf()
kenjis Aug 27, 2023
b9efbfc
docs: add @immutable
kenjis Aug 27, 2023
aa93ae2
test: add feature test for auto routing legacy
kenjis Aug 27, 2023
681f74d
fix: auto routing legacy does not work at all
kenjis Aug 27, 2023
1804bab
Merge pull request #7871 from kenjis/fix-auto-route-legacy
samsonasik Aug 28, 2023
4570941
fix: replace `config(DocTypes::class)` with `new DocTypes()`
kenjis Aug 29, 2023
3474bc5
refactor: add way to chnage DocTypes for testing
kenjis Aug 29, 2023
c1cd351
build(deps-dev): update rector/rector requirement from 0.18.0 to 0.18.1
dependabot[bot] Aug 29, 2023
bb0cd96
Merge pull request #7868 from kenjis/fix-factories-return-new-instance
kenjis Aug 29, 2023
d043f4a
Merge pull request #7869 from kenjis/add-immutable-to-config
kenjis Aug 29, 2023
defd761
Merge pull request #7877 from codeigniter4/dependabot/composer/rector…
samsonasik Aug 30, 2023
f34580d
docs: fix or remove @param
kenjis Aug 30, 2023
f7e6cff
Merge pull request #7879 from kenjis/docs-phpdoc-param
kenjis Aug 30, 2023
ab63068
test: add tests for reverse routing
kenjis Aug 30, 2023
ec489c3
fix: reverse routing causes ErrorException
kenjis Aug 30, 2023
a9e44f0
refactor: remove uneeded variable and if statement
kenjis Aug 30, 2023
50cb4b4
test: update assertion
kenjis Aug 30, 2023
a98c0a6
[DebugBar] make rotate class less broad
sanchawebo Aug 30, 2023
c5fee43
docs: fix doc comments
kenjis Aug 30, 2023
a5b4f9b
fix: now you can use SSL with port 465
kenjis Aug 30, 2023
2d0fa2e
docs: improve descriptions
kenjis Aug 30, 2023
37ebc6f
Merge pull request #7872 from kenjis/fix-FactoriesCache-error
kenjis Aug 31, 2023
fe40d94
test: add test for forceGlobalSecureRequests
kenjis Sep 2, 2023
c8fc3d8
fix: HTTP tests fail when forceGlobalSecureRequests is true
kenjis Sep 2, 2023
5d40f69
Merge pull request #7867 from kenjis/fix-feature-test-buffering
kenjis Sep 4, 2023
28c71eb
build(deps): bump actions/checkout from 3 to 4
dependabot[bot] Sep 4, 2023
546087e
Merge pull request #7895 from codeigniter4/dependabot/github_actions/…
samsonasik Sep 4, 2023
ed5d07e
Merge pull request #7880 from kenjis/fix-reverse-route-nested-parenth…
kenjis Sep 4, 2023
39c5df6
Merge pull request #7883 from kenjis/fix-email-tls
kenjis Sep 4, 2023
398e44b
Merge pull request #7882 from sanchawebo/rotateFix
kenjis Sep 4, 2023
daa8811
Merge pull request #7890 from kenjis/fix-test-forceGlobalSecureRequests
kenjis Sep 4, 2023
01a12b1
docs: add changelog
kenjis Aug 29, 2023
228ece2
Prep for 4.4.1 release
kenjis Aug 29, 2023
fe9c7ea
Merge pull request #7874 from kenjis/release-4.4.1
kenjis Sep 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy-apidocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ jobs:
git config --global user.name "${GITHUB_ACTOR}"

- name: Checkout source
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: source

- name: Checkout target
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: codeigniter4/api
token: ${{ secrets.ACCESS_TOKEN }}
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/deploy-distributables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0 # fetch all tags

Expand Down Expand Up @@ -48,12 +48,12 @@ jobs:
git config --global user.name "${GITHUB_ACTOR}"

- name: Checkout source
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: source

- name: Checkout target
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: codeigniter4/framework
token: ${{ secrets.ACCESS_TOKEN }}
Expand Down Expand Up @@ -98,12 +98,12 @@ jobs:
git config --global user.name "${GITHUB_ACTOR}"

- name: Checkout source
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: source

- name: Checkout target
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: codeigniter4/appstarter
token: ${{ secrets.ACCESS_TOKEN }}
Expand Down Expand Up @@ -148,12 +148,12 @@ jobs:
git config --global user.name "${GITHUB_ACTOR}"

- name: Checkout source
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: source

- name: Checkout target
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: codeigniter4/userguide
token: ${{ secrets.ACCESS_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-userguide-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-coveralls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-phpunit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
sudo apt-get install --fix-broken

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-serviceless-phpunit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
sudo apt-get install --fix-broken

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-autoreview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-deptrac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-phpcpd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-phpstan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
fail-fast: false
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-psalm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-rector.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- utils
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-scss.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Node
uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-userguide.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Detect usage of tabs in RST files
run: php utils/check_tabs_in_rst.php
Expand Down
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
# Changelog

## [v4.4.1](https://github.com/codeigniter4/CodeIgniter4/tree/v4.4.1) (2023-09-05)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.4.0...v4.4.1)

### Fixed Bugs

* docs: add missing Config updates for Hot Reloading by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7862
* fix: auto route legacy does not work by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7871
* fix: Factories may not return shared instance by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7868
* fix: replace `config(DocTypes::class)` with `new DocTypes()` by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7872
* fix: FeatureTest may cause risky tests by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7867
* fix: reverse routing causes ErrorException by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7880
* fix: Email library forces to switch to TLS when setting port 465 by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7883
* fix: [DebugBar] make CSS rotate class less broad by @sanchawebo in https://github.com/codeigniter4/CodeIgniter4/pull/7882
* fix: FeatureTest fails when forceGlobalSecureRequests is true by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/7890

## [v4.4.0](https://github.com/codeigniter4/CodeIgniter4/tree/v4.4.0) (2023-08-25)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.3.8...v4.4.0)

Expand Down
5 changes: 5 additions & 0 deletions admin/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
If you release a new minor version.

* Create PR to merge `4.x` into `develop` and merge it
* Rename the current minor version (e.g., `4.4`) in Setting > Branches >
"Branch protection rules" to the next minor version. E.g. `4.4` → `4.5`
* Delete the merged `4.x` branch (This closes all PRs to the branch)
* Do the regular release process. Go to the next "Changelog" section

Expand Down Expand Up @@ -77,6 +79,7 @@ the existing content.
* fill in the "All Changes" section, and add it to **upgrading.rst**
* git diff --name-status origin/master -- . ':!system'
* Remove the section titles that have no items
* Update the "from" version in the title. E.g., `from 4.3.x` → `from 4.3.8`
* Commit the changes with `Prep for 4.x.x release` and push to origin
* Create a new PR from `release-4.x.x` to `develop`:
* Title: `Prep for 4.x.x release`
Expand Down Expand Up @@ -113,6 +116,8 @@ the existing content.
* "[Deploy Distributable Repos](https://github.com/codeigniter4/CodeIgniter4/actions/workflows/deploy-distributables.yml)", the main repo
* "[Deploy Production](https://github.com/codeigniter4/userguide/actions/workflows/deploy.yml)", UG repo
* "[pages-build-deployment](https://github.com/codeigniter4/userguide/actions/workflows/pages/pages-build-deployment)", UG repo
* Check if "CodeIgniter4.x.x.epub" is added to UG repo. "CodeIgniter.epub" was
created when v4.3.8 was released.
* Fast-forward `develop` branch to catch the merge commit from `master`
```console
git fetch origin
Expand Down
19 changes: 9 additions & 10 deletions admin/css/debug-toolbar/toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,15 @@
// Give room for OS X scrollbar
white-space: nowrap;
z-index: 10000;
// Endless rotate
.rotate {
animation: toolbar-rotate 9s linear infinite;
}
@keyframes toolbar-rotate {
to {
transform: rotate(360deg);
}
}
}

// Fixed top
Expand Down Expand Up @@ -501,13 +510,3 @@
.debug-bar-noverflow {
overflow: hidden;
}

/* ENDLESS ROTATE */
.rotate {
animation: rotate 9s linear infinite;
}
@keyframes rotate {
to {
transform: rotate(360deg);
}
}
2 changes: 2 additions & 0 deletions app/Config/Autoload.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*
* NOTE: This class is required prior to Autoloader instantiation,
* and does not extend BaseConfig.
*
* @immutable
*/
class Autoload extends AutoloadConfig
{
Expand Down
3 changes: 3 additions & 0 deletions app/Config/DocTypes.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace Config;

/**
* @immutable
*/
class DocTypes
{
/**
Expand Down
6 changes: 5 additions & 1 deletion app/Config/Email.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ class Email extends BaseConfig
public bool $SMTPKeepAlive = false;

/**
* SMTP Encryption. Either tls or ssl
* SMTP Encryption.
*
* @var string '', 'tls' or 'ssl'. 'tls' will issue a STARTTLS command
* to the server. 'ssl' means implicit SSL. Connection on port
* 465 should set this to ''.
*/
public string $SMTPCrypto = 'tls';

Expand Down
3 changes: 3 additions & 0 deletions app/Config/ForeignCharacters.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

use CodeIgniter\Config\ForeignCharacters as BaseForeignCharacters;

/**
* @immutable
*/
class ForeignCharacters extends BaseForeignCharacters
{
}
2 changes: 2 additions & 0 deletions app/Config/Mimes.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*
* When working with mime types, please make sure you have the ´fileinfo´
* extension enabled to reliably detect the media types.
*
* @immutable
*/
class Mimes
{
Expand Down
2 changes: 2 additions & 0 deletions app/Config/Modules.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
*
* NOTE: This class is required prior to Autoloader instantiation,
* and does not extend BaseConfig.
*
* @immutable
*/
class Modules extends BaseModules
{
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"phpunit/phpcov": "^8.2",
"phpunit/phpunit": "^9.1",
"predis/predis": "^1.1 || ^2.0",
"rector/rector": "0.18.0",
"rector/rector": "0.18.1",
"vimeo/psalm": "^5.0"
},
"suggest": {
Expand Down
Loading