Skip to content

docs: improve on Site URIs setting #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 7, 2023
Merged

docs: improve on Site URIs setting #7873

merged 6 commits into from
Sep 7, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 29, 2023

Description
See https://forum.codeigniter.com/showthread.php?tid=88363

  • add about $indexPage

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Aug 29, 2023
@kenjis kenjis changed the title docs: improve on Site URIs docs: improve on Site URIs setting Aug 29, 2023
@kenjis
Copy link
Member Author

kenjis commented Aug 31, 2023

Can someone review?

@kenjis kenjis added the help wanted More help is needed for the proper resolution of an issue or pull request label Sep 4, 2023
datamweb
datamweb reviewed Sep 7, 2023
View reviewed changes
user_guide_src/source/installation/running.rst Outdated
#. $baseURL
Set your base URL to ``$baseURL``. If you need more flexibility, the baseURL may
be set within the :ref:`.env <dotenv-file>` file as ``app.baseURL = 'http://example.com/'``.
(Always use a trailing slash on your base URL!)
Copy link
Contributor

@datamweb datamweb Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some people having problems in the forum. I think it is prominently bold.

Copy link
Member Author

@kenjis kenjis Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to make "Always use a trailing slash on your base URL!" bold?

Copy link
Contributor

@datamweb datamweb Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Yes.

Copy link
Member Author

@kenjis kenjis Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

datamweb
datamweb approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit ec8ba91 into codeigniter4:develop Sep 7, 2023
@kenjis kenjis deleted the docs-baseURL branch September 7, 2023 23:59
@kenjis
Copy link
Member Author

kenjis commented Sep 7, 2023

@datamweb Thank you for the review!

@neznaika0
Copy link
Contributor

neznaika0 commented Sep 8, 2023

@kenjis is there some important reason not to remove the index? Most people ask a question and no one wants to have an index in the URL. Should it be disabled by default?

@kenjis
Copy link
Member Author

kenjis commented Sep 8, 2023

It came from CI3. Probably, the URI with index.php always works, but the URI without it needs mod_rewrite on Apache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests for documentation only help wanted More help is needed for the proper resolution of an issue or pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @neznaika0 @datamweb