Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 21, 2023

Description
Now 4.4 branch is broken.

  • update cs and add missing @return
   1) user_guide_src/source/outgoing/response/003.php (blank_line_before_statement)
      ---------- begin diff ----------
--- /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/outgoing/response/003.php
+++ /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/outgoing/response/003.php
@@ -6,5 +6,6 @@
 ];
 
 return $this->response->setJSON($data);
+
 // or
 return $this->response->setXML($data);

      ----------- end diff -----------
 Error: Method CodeIgniter\Exceptions\FrameworkException::forCopyError() has no return type specified.
 ------ ---------------------------------------------------------------------- 
  Line   system/Exceptions/FrameworkException.php                              
 ------ ---------------------------------------------------------------------- 
  50     Method CodeIgniter\Exceptions\FrameworkException::forCopyError() has  
         no return type specified.                                             
 ------ ---------------------------------------------------------------------- 

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.4 label Aug 21, 2023
@kenjis
Copy link
Member Author

kenjis commented Aug 22, 2023

Now 4.4 branch is broken. Please review.

@kenjis kenjis mentioned this pull request Aug 22, 2023
22 tasks
@kenjis kenjis merged commit 015b7d9 into codeigniter4:4.4 Aug 22, 2023
@kenjis kenjis deleted the fix-ga-check-fail branch August 22, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants