Skip to content

style: update cs #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

style: update cs #7820

merged 1 commit into from
Aug 15, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 14, 2023 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member Author

kenjis commented Aug 15, 2023

This affects all PRs. Please review soon.

paulbalandan
paulbalandan approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line before // no break seems to be a bug.

@kenjis kenjis merged commit 598331e into codeigniter4:develop Aug 15, 2023
@kenjis kenjis deleted the style-update-cs branch August 15, 2023 22:38
@kenjis
Copy link
Member Author

kenjis commented Aug 15, 2023 •
edited
Loading

Yes, it certainly seems a little odd, but since there is no real harm, let's go with it for now.

@kenjis kenjis mentioned this pull request Aug 16, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @paulbalandan