Skip to content

refactor: move callExit() to index.php #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2023
Merged

refactor: move callExit() to index.php #7800

merged 4 commits into from
Aug 14, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 9, 2023 •
edited
Loading

Description
The method is not needed.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.4 labels Aug 9, 2023
@kenjis kenjis mentioned this pull request Aug 9, 2023
Merged
5 tasks
@kenjis kenjis force-pushed the refactor-remove-callExit branch from 7b45987 to 86a7715 Compare August 9, 2023 08:45
samsonasik
samsonasik reviewed Aug 11, 2023
View reviewed changes
@samsonasik samsonasik added the breaking change Pull requests that may break existing functionalities label Aug 11, 2023
MGatner
MGatner approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to hear any more from @samsonasik but I am good with this.

@samsonasik
Copy link
Member

samsonasik commented Aug 12, 2023

I don't use the callExit(), but that definatelly a bc break, a bc break note is needed if that need to be removed.

@kenjis kenjis force-pushed the refactor-remove-callExit branch from b90efb1 to 13251a2 Compare August 13, 2023 03:06
@kenjis
Copy link
Member Author

kenjis commented Aug 13, 2023

@samsonasik Added docs: 13251a2

@kenjis kenjis mentioned this pull request Aug 13, 2023
Closed
22 tasks
@kenjis kenjis merged commit 4799e78 into codeigniter4:4.4 Aug 14, 2023
@kenjis kenjis deleted the refactor-remove-callExit branch August 14, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis @samsonasik @datamweb @MGatner