Skip to content

Conversation

@ibrataha8
Copy link

@ibrataha8 ibrataha8 commented Jul 23, 2023

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would like to see whether this PR will be merged or not. Similar to this in Laravel.

In any case, it needs to be signed.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick read doesn't bring up anything definitive about ASCII versus UTF-8 specs for Markdown. I'm not sure what the implications of this are but it seems a common practice and I'll about some emojis 😅😉🙃🫶

@ibrataha8
Copy link
Author

@MGatner Thank You

@kenjis
Copy link
Member

kenjis commented Jul 24, 2023

We can of course use UTF-8 in Markdown. These emojis make sense.
I'm fine. But we need your GPG sign.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

ibrataha8 and others added 2 commits July 25, 2023 21:25
Co-authored-by: kenjis <[email protected]>
Co-authored-by: kenjis <[email protected]>
@ibrataha8
Copy link
Author

@kenjis If you like my addition, don't forget to add it. I'm just improving user experience

kenjis
kenjis previously approved these changes Jul 25, 2023
@kenjis kenjis changed the title update readme add icons to title docs: update readme add icons to title Jul 25, 2023
@totoprayogo1916
Copy link
Contributor

@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Aug 1, 2023
@kenjis kenjis dismissed their stale review August 1, 2023 02:08

No GPG sign

@kenjis
Copy link
Member

kenjis commented Aug 1, 2023

@ibrataha8 I had overlooked the fact that the first commit was not signed.

You must GPG-sign your work.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

And there are two more README. See #7732 (comment)
So it would be nice that you add emojis to them in this PR.

@github-actions github-actions bot added the stale Pull requests with conflicts label Sep 20, 2023
@github-actions
Copy link

👋 Hi, @ibrataha8!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis removed the stale Pull requests with conflicts label Sep 20, 2023
@kenjis
Copy link
Member

kenjis commented Dec 20, 2023

See codeigniter4/shield#983

@kenjis kenjis closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GPG-Signing needed Pull requests that need GPG-Signing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants