-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: update readme add icons to title #7732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
datamweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I would like to see whether this PR will be merged or not. Similar to this in Laravel.
In any case, it needs to be signed.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
MGatner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick read doesn't bring up anything definitive about ASCII versus UTF-8 specs for Markdown. I'm not sure what the implications of this are but it seems a common practice and I'll about some emojis 😅😉🙃🫶
|
@MGatner Thank You |
|
We can of course use UTF-8 in Markdown. These emojis make sense. |
Co-authored-by: kenjis <[email protected]>
Co-authored-by: kenjis <[email protected]>
|
@kenjis If you like my addition, don't forget to add it. I'm just improving user experience |
|
@ibrataha8 I had overlooked the fact that the first commit was not signed. You must GPG-sign your work. And there are two more README. See #7732 (comment) |
|
👋 Hi, @ibrataha8! |
Checklist: