Skip to content

Conversation

@paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan force-pushed the composer-normalize branch 2 times, most recently from f53529e to 9ee3c03 Compare July 21, 2023 06:26
@paulbalandan paulbalandan marked this pull request as draft July 21, 2023 06:31
@paulbalandan paulbalandan marked this pull request as ready for review July 21, 2023 09:55
@kenjis
Copy link
Member

kenjis commented Jul 24, 2023

Why don't you require (--dev) composer-normalize?

@paulbalandan
Copy link
Member Author

composer-normalize requires PHP 8.1, so this would not work on lower PHP when running the workflows

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use Normalize in my own projects, very helpful. This is a significant addition to the workflow spec - is it worth making it standalone?

@kenjis
Copy link
Member

kenjis commented Jul 24, 2023

We can use v2.28 on PHP 7.4.

$ composer require --dev ergebnis/composer-normalize
Cannot use ergebnis/composer-normalize's latest version 2.33.0 as it requires php ~8.1.0 || ~8.2.0 which is not satisfied by your platform.
./composer.json has been updated
Running composer update ergebnis/composer-normalize
Loading composer repositories with package information
Updating dependencies
Lock file operations: 6 installs, 0 updates, 0 removals
  - Locking ergebnis/composer-normalize (2.28.3)
  - Locking ergebnis/json-normalizer (2.1.0)
  - Locking ergebnis/json-printer (3.2.0)
  - Locking ergebnis/json-schema-validator (2.0.0)
  - Locking justinrainbow/json-schema (5.2.12)
  - Locking localheinz/diff (1.1.1)

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Aug 1, 2023
@paulbalandan paulbalandan merged commit c56edf2 into codeigniter4:develop Aug 1, 2023
@paulbalandan paulbalandan deleted the composer-normalize branch August 1, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants