-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: Add composer-normalize to auto-review testing of composer.json
#7727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add composer-normalize to auto-review testing of composer.json
#7727
Conversation
f53529e to
9ee3c03
Compare
9ee3c03 to
fffe097
Compare
|
Why don't you require (--dev) composer-normalize? |
|
composer-normalize requires PHP 8.1, so this would not work on lower PHP when running the workflows |
MGatner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use Normalize in my own projects, very helpful. This is a significant addition to the workflow spec - is it worth making it standalone?
|
We can use v2.28 on PHP 7.4. |
8964694 to
3ef4d42
Compare
kenjis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist: