Skip to content

chore: [4.4] update phpstan-baseline.php #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: [4.4] update phpstan-baseline.php #7721

wants to merge 1 commit into from

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jul 21, 2023 •
edited
Loading

Needs #7722

Description
Update phpstan-baseline.php for #7713
Fixes https://github.com/codeigniter4/CodeIgniter4/actions/runs/5617352335/job/15221317246

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the 4.4 label Jul 21, 2023
@kenjis kenjis force-pushed the fix-phpstan-errors branch from b3beb4c to b5bea41 Compare July 21, 2023 01:09
@kenjis kenjis marked this pull request as draft July 21, 2023 01:09
@kenjis kenjis force-pushed the fix-phpstan-errors branch from b5bea41 to 66429c3 Compare July 21, 2023 02:06
@kenjis kenjis marked this pull request as ready for review July 21, 2023 02:06
@paulbalandan
Copy link
Member

paulbalandan commented Jul 21, 2023

Since the 4.4 branch is not yet released, can we instead add the type declarations/ PHPDocs to those new classes (HotReloader, SiteURI, etc.) and other additions?

kenjis
kenjis commented Jul 21, 2023
View reviewed changes
phpstan-baseline.php
'message' => '#^Method CodeIgniter\\\\Exceptions\\\\FrameworkException\\:\\:forInvalidDirectory\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Exceptions/FrameworkException.php',
];
Copy link
Member Author

@kenjis kenjis Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulbalandan The return type should be static, but we cannot use it yet:

CodeIgniter4/system/Exceptions/FrameworkException.php

Lines 36 to 39 in dec4b71

public static function forInvalidDirectory(string $path)
{
return new static(lang('Core.invalidDirectory', [$path]));
}

Copy link
Member

@paulbalandan paulbalandan Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then a PHPDoc should suffice.

@kenjis kenjis marked this pull request as draft July 21, 2023 03:15
@kenjis kenjis mentioned this pull request Jul 21, 2023
Merged
3 tasks
@kenjis
Copy link
Member Author

kenjis commented Jul 22, 2023

Closed by #7723

@kenjis kenjis closed this Jul 22, 2023
@kenjis kenjis deleted the fix-phpstan-errors branch July 22, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan