Skip to content

chore: disableProcessTimeout in analyze script #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

chore: disableProcessTimeout in analyze script #7715

merged 1 commit into from
Jul 24, 2023

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Jul 19, 2023

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan changed the title chore: disableProcessTimeout in analyze Composer chore: disableProcessTimeout in analyze script Jul 19, 2023
@paulbalandan
Copy link
Member

paulbalandan commented Jul 19, 2023

Where does it timeout? phpstan or rector?

@MGatner
Copy link
Member

MGatner commented Jul 23, 2023

It's what we recommend in DevKit. I always add it myself, not sure if it has ever prevented a timeout or not though.

kenjis
kenjis approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my environment, Rector times out.

@kenjis
Copy link
Member

kenjis commented Jul 24, 2023

@ddevsr Can you also update https://github.com/codeigniter4/devkit/blob/edf1036c56ee09b322261f0bc9eae9dc4f5fffa8/composer.json#L51 ?

@ddevsr ddevsr mentioned this pull request Jul 24, 2023
Merged
@ddevsr
Copy link
Collaborator Author

ddevsr commented Jul 24, 2023

@ddevsr Can you also update https://github.com/codeigniter4/devkit/blob/edf1036c56ee09b322261f0bc9eae9dc4f5fffa8/composer.json#L51 ?

@kenjis Done

@samsonasik samsonasik merged commit fc4387f into codeigniter4:develop Jul 24, 2023
@samsonasik
Copy link
Member

samsonasik commented Jul 24, 2023

Thank you @ddevsr

@ddevsr ddevsr deleted the patch-1 branch July 24, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ddevsr @paulbalandan @MGatner @kenjis @samsonasik