-
Notifications
You must be signed in to change notification settings - Fork 2k
Adjust registering of custom fixers for PHP 8.0+ only #7712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What happened when we (or contributors) use PHP 7.4? |
|
If you are using |
|
Until we stop supporting PHP 7.4, I guess the only way is to fix the version of php-cs-fixer so that PHP 7.4 does not cause the error? |
a6123d6 to
00c7086
Compare
|
I pushed a different approach. I disabled registering custom fixers for PHP 7.4. Only for PHP 8.0 and above |
kenjis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked on PHP 7.4. Thank you!
Description
php-cs-fixerrecently adjusted the return types of itsPregmethods. Yes, that class is internal butcs-configdepended on that. With the return type change, it used the nativepreg_*functions instead. Sincecs-configneeds^8.0.1the fix won't work with 7.4.Checklist: