Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jun 29, 2023

Description
See #6310

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@iRedds
Copy link
Collaborator

iRedds commented Jun 29, 2023

I have a question. Should the cachePage() method return any result?
I mean that the result of the cachePage() method is not used anywhere and is not tested in any way.
Maybe it makes sense not to return anything at all?

@michalsn
Copy link
Member

Despite if this is used or tested. I would like to know the result of the operation to determine whether it was successful or not. Some use cases may not care, but some may. It doesn't hurt to have an option.

@kenjis kenjis merged commit af377af into codeigniter4:develop Jun 29, 2023
@kenjis kenjis deleted the fix-phpdoc-param-CodeIgniter branch June 29, 2023 10:46
@kenjis
Copy link
Member Author

kenjis commented Jun 29, 2023

CacheInterface::save() returns bool. So it seems better to return the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants